Skip to content

Feature/parareal pfasst redesign

Jacques Xing requested to merge CFD-Xing/nektar:feature/parareal-pfasst-redesign into master

Issue/feature addressed

This is a redesign of the Parareal and PFASST subclasses.

Proposed solution

Implementation

This MR has been split into:

  • Update driver class and subclasses to use default destructor (see !1624 (merged))
  • Add additional SDC test to the CI (see !1621 (merged))
  • Move SVVVarDiffCoeff from UnsteadySystem.h to UnsteadyViscousBurgers.cpp (see !1626 (closed))
  • Fix typo in user-guide and fix bug for parallel-in-time FieldConvert (see !1645 (merged))
  • Add member function in MPI communicator to check if time-parallel is enable (see !1647 (merged))
  • Update default global system solver parameters for paralell-in-time (see !1649 (merged))
  • Update AssemblyMap to reduce verbosity when using parallel-in-time (see !1651 (merged))
  • Add safety check for FinTime parameter for parallel-in-time (see !1652 (merged))

Tests

  • solvers/ADRSolver/Tests/PFASSTDriverUnsteadyAdvection2D.tst
  • solvers/ADRSolver/Tests/PararealDriverUnsteadyAdvection2D.tst

Suggested reviewers

Please suggest any people who would be appropriate to review your code.

Notes

Please add any other information that could be useful for reviewers.

Checklist

  • Functions and classes, or changes to them, are documented.
  • [ ] User guide/documentation is updated.
  • Changelog is updated.
  • Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • [ ] License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).
Edited by Jacques Xing

Merge request reports