Skip to content
Snippets Groups Projects

Add CMake support for execution space specific but implementation generic operators

Merged Add CMake support for execution space specific but implementation generic operators
CFD-Xing/nektar:feature/redesign/generic-operators into feature/redesign
All threads resolved!
Merged Jacques Xing requested to merge CFD-Xing/nektar:feature/redesign/generic-operators into feature/redesign
All threads resolved!

Issue/feature addressed

Some operators do not have a StdMat or a SumFac specific implementation. The implementation should be "generic".

Proposed solution

Update the Operators/CMakeList.txt to recognize a *Generic.hpp header file.

Also update to use SumFac implementation for Kokkos backend.

Also simplify operator defaulting.

Implementation

Tests

Suggested reviewers

Notes

Checklist

  • Functions and classes, or changes to them, are documented.
  • [ ] User guide/documentation is updated.
  • [ ] Changelog is updated.
  • Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).
Edited by Jacques Xing

Merge request reports

Merge request pipeline #7492 passed

Stage: build-env-default
    Stage: build-env-full
      Stage: build-and-test
        Stage: quality-checks
          Stage: package-env
            Stage: package-build
              Stage: package-build-dev
                Stage: package-test

                  Merge request pipeline passed for 12ebd130

                  Merged by Chris CantwellChris Cantwell 7 months ago (Jul 24, 2024 9:44am UTC)

                  Merge details

                  • Changes merged into feature/redesign with a1e302f6 (commits were squashed).
                  • Deleted the source branch.

                  Activity

                  Filter activity
                  • Approvals
                  • Assignees & reviewers
                  • Comments (from bots)
                  • Comments (from users)
                  • Commits & branches
                  • Edits
                  • Labels
                  • Lock status
                  • Mentions
                  • Merge request status
                  • Tracking
                • Jacques Xing
                • Jacques Xing
                • Jacques Xing added 1 commit

                  added 1 commit

                  • 9a6ef2ba - Update NeuBndCond as generic

                  Compare with previous version

                • Jacques Xing added 1 commit

                  added 1 commit

                  Compare with previous version

                • Jacques Xing added 1 commit

                  added 1 commit

                  • f635ec30 - Update AssmbScatr as generic

                  Compare with previous version

                • Jacques Xing added 1 commit

                  added 1 commit

                  • 7656efe3 - Fix Operators/CMakeLists.txt for CUDA

                  Compare with previous version

                • Jacques Xing marked this merge request as ready

                  marked this merge request as ready

                • Jacques Xing changed title from Draft: Feature/redesign/generic operators to Add CMake support for execution space specific but implementation generic operators

                  changed title from Draft: Feature/redesign/generic operators to Add CMake support for execution space specific but implementation generic operators

                • Jacques Xing marked the checklist item Functions and classes, or changes to them, are documented. as completed

                  marked the checklist item Functions and classes, or changes to them, are documented. as completed

                • Jacques Xing marked the checklist item Suitable tests added for new functionality. as completed

                  marked the checklist item Suitable tests added for new functionality. as completed

                • Jacques Xing marked the checklist item License added to any new files. as completed

                  marked the checklist item License added to any new files. as completed

                • Jacques Xing marked the checklist item Contributed code is correctly formatted. (See the contributing guidelines). as completed

                  marked the checklist item Contributed code is correctly formatted. (See the contributing guidelines). as completed

                • Jacques Xing marked the checklist item No extraneous files have been added (e.g. compiler output or test data files). as completed

                  marked the checklist item No extraneous files have been added (e.g. compiler output or test data files). as completed

                • Jacques Xing assigned to @ccantwel

                  assigned to @ccantwel

                • Jacques Xing requested review from @ssherw

                  requested review from @ssherw

                • Jacques Xing added 3 commits

                  added 3 commits

                  Compare with previous version

                • Jacques Xing changed the description

                  changed the description

                • Jacques Xing added 3 commits

                  added 3 commits

                  Compare with previous version

                • Jacques Xing added 3 commits

                  added 3 commits

                  • 3fcbf82f...b57a0c4e - 2 commits from branch nektar:feature/redesign
                  • ccf902d0 - Merge remote-tracking branch 'upstream/feature/redesign' into feature/redesign/generic-operators

                  Compare with previous version

                • Jacques Xing added 1 commit

                  added 1 commit

                  • 7aa6bafc - Update for command-line argument

                  Compare with previous version

                • Jacques Xing marked this merge request as draft

                  marked this merge request as draft

                • Jacques Xing added 7 commits

                  added 7 commits

                  • 7aa6bafc...0ad2a77c - 6 commits from branch nektar:feature/redesign
                  • cbb3f75b - Add CMake support for execution space specific but implementation generic operators

                  Compare with previous version

                • Jacques Xing added 4 commits

                  added 4 commits

                  Compare with previous version

                  Toggle commit list
                • Jacques Xing marked this merge request as ready

                  marked this merge request as ready

                • Jacques Xing changed the description

                  changed the description

                • Jacques Xing added 1 commit

                  added 1 commit

                  Compare with previous version

                • Chris Cantwell resolved all threads

                  resolved all threads

                • Chris Cantwell approved this merge request

                  approved this merge request

                • Chris Cantwell mentioned in commit a1e302f6

                  mentioned in commit a1e302f6

                • Chris Cantwell merged

                  merged

                  • Please register or sign in to reply