Remove move semantics and use StdMat as default implementation for all operators
- Remove move semantics during operator construction
- Add missing operator() function for consistency
- Consistently use
StdMatas default implementation for all operators
Merge request reports
Activity
assigned to @ccantwel
added 1 commit
- 92f9a420 - Consistently use StdMat as default implementation for all operators
added 1 commit
- ea4a7527 - Consistently use StdMat as default implementation for all operators (bis)
7 7 template <> 8 8 std::string OperatorConjGradImpl<double, ImplStdMat>::className = 9 9 GetOperatorFactory<double>().RegisterCreatorFunction( 10 "ConjGrad", OperatorConjGradImpl<double, ImplStdMat>::instantiate, ""); 10 "ConjGradStdMat", OperatorConjGradImpl<double, ImplStdMat>::instantiate, 7 7 template <> 8 8 std::string OperatorDiagPreconImpl<double, ImplStdMat>::className = 9 9 GetOperatorFactory<double>().RegisterCreatorFunction( 10 "DiagPrecon", OperatorDiagPreconImpl<double, ImplStdMat>::instantiate, 11 ""); 10 "DiagPreconStdMat", 7 7 template <> 8 8 std::string OperatorFwdTransImpl<double, ImplStdMat>::className = 9 9 GetOperatorFactory<double>().RegisterCreatorFunction( 10 "FwdTrans", OperatorFwdTransImpl<double, ImplStdMat>::instantiate, ""); 10 "FwdTransStdMat", OperatorFwdTransImpl<double, ImplStdMat>::instantiate, What was the reasoning for choosing StdMat here? From what I can see in the code, it seems to use the default implementation to instantiate the inner operators. I wonder if we should be explicitly choosing the StdMat version of these operators, or instead calling it "Native" or "Host" again?
Probably allowing us to take the default implementation of the inner operators would be the best, since they can be set to the optimal choice for the architecture/problem. Otherwise we will proliferate a large combination of different FwdTrans implementations.
An alternative choice is to provide
SetConjGradOp,SetPreconOp,SetMassOpandSetIProductWRTBaseOpfunctions to enable the user to provide these?A point for discussion!
7 7 template <> 8 8 std::string OperatorConjGradImpl<double, ImplStdMat>::className = 9 9 GetOperatorFactory<double>().RegisterCreatorFunction( 10 "ConjGrad", OperatorConjGradImpl<double, ImplStdMat>::instantiate, ""); 10 "ConjGradStdMat", OperatorConjGradImpl<double, ImplStdMat>::instantiate, 11 "..."); 14 14 virtual ~OperatorAssmbScatr() = default; 15 15 16 16 OperatorAssmbScatr(const MultiRegions::ExpListSharedPtr &expansionList) 17 : Operator<TData>(expansionList) 17 : Operator<TData>(std::move(expansionList)) changed this line in version 7 of the diff
added 8 commits
-
a805b5b8...1ca3d18b - 2 commits from branch
nektar:master - 49d85bf1 - Use move semantics consistently
- dbce272b - Clang-format
- a3050461 - Consistently use StdMat as default implementation for all operators
- c99296a7 - Consistently use StdMat as default implementation for all operators (bis)
- 6048fff3 - Clang-format
- db526ab3 - Fix operator registration in factory
Toggle commit list-
a805b5b8...1ca3d18b - 2 commits from branch
