Fix Null and Diagonal preconditioner operator implementation and add test
- Fix null preconditioner implementation for local space
- Fix diagonal preconditioner implementation for local space
- Create a
tests/init_nullpreconfields.hpp
subclass to reduce code duplication. - Create a
tests/init_diagpreconfields.hpp
subclass to reduce code duplication. - Consistently add test for seg, quad, tri, hex, prism, pyr, and tet.
- Use Nektar++ for reference solution.
Remark: Current implementation of the diagonal preconditioner is very inefficient.
Note: MR!48 should be merged first
Edited by Jacques Xing
Merge request reports
Activity
added 1 commit
- 9da0e4aa - Fix Null and Diagonal preconditioner implementation and add test
assigned to @ccantwel
mentioned in merge request !45 (merged)
@ccantwel This is ready to be merged after !48 (merged). Both the null and the diagonal preconditioners are directly compared to Nektar++. This also indirectly validate the implementation of the Neumann and Robin boundary conditions.
added 3 commits
-
9da0e4aa...229d7c18 - 2 commits from branch
nektar:master
- fe6905e4 - Merge remote-tracking branch 'upstream/master' into precond-operator
-
9da0e4aa...229d7c18 - 2 commits from branch
mentioned in commit ff5c0d09
Please register or sign in to reply