Skip to content
Snippets Groups Projects

Fix Null and Diagonal preconditioner operator implementation and add test

Merged Jacques Xing requested to merge CFD-Xing/redesign-prototypes:precond-operator into master
  • Fix null preconditioner implementation for local space
  • Fix diagonal preconditioner implementation for local space
  • Create a tests/init_nullpreconfields.hpp subclass to reduce code duplication.
  • Create a tests/init_diagpreconfields.hpp subclass to reduce code duplication.
  • Consistently add test for seg, quad, tri, hex, prism, pyr, and tet.
  • Use Nektar++ for reference solution.

Remark: Current implementation of the diagonal preconditioner is very inefficient.

Note: MR!48 should be merged first

Edited by Jacques Xing

Merge request reports

Approved by

Merged by Chris CantwellChris Cantwell 1 year ago (Nov 7, 2023 9:55am UTC)

Merge details

  • Changes merged into master with ff5c0d09 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading