Skip to content
Snippets Groups Projects

remove unnecessary std::move from Operator ctors

Merged Pavol Margitfalvi requested to merge remove_unnecessary_moves into master

Initially a pass-by-value then std::move pattern was used in the Operator constructors as it can be more efficient if an r-value is passed as an argument. Later this was changed to pass by const reference, since the performance impact is minimal and it is simpler code that doesn't allow the user to use the moved value. However the std::moves were left over, even though they now do nothing. This change removes them.

Merge request reports

Approved by

Merged by Chris CantwellChris Cantwell 1 year ago (May 25, 2023 8:42pm UTC)

Merge details

  • Changes merged into master with 650da278.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading